Reject negative ln inputs#22276
Open
akmhatey-ai wants to merge 3 commits into
Open
Conversation
github-actions
Bot
added
sqllogictest
kumarUjjawal
left a comment
kumarUjjawal
left a comment
Contributor
There was a problem hiding this comment.
I think we also need to look into other such log functions which also return NaN.
DataFusion CLI v53.1.0
> > SELECT
ln(2.0) AS ln_pos,
log10(100.0) AS log10_pos,
log(-1.0) AS log_neg,
log2(-1.0) AS log2_neg,
log10(-1.0) AS log10_neg;
+--------------------+-----------+---------+----------+-----------+
| ln_pos | log10_pos | log_neg | log2_neg | log10_neg |
+--------------------+-----------+---------+----------+-----------+
| 0.6931471805599453 | 2.0 | NaN | NaN | NaN |
+--------------------+-----------+---------+----------+-----------+
1 row(s) fetched.
Elapsed 0.004 seconds.
Contributor
There was a problem hiding this comment.
We don't need a new file for the ln we can extend the already available macro for this.
Author
|
Updated in 48152f0. Covered the other negative-input cases from your example:
Validation run:
One limitation: full |
This was referenced May 28, 2026
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ln(-1.0::float8)should error, not return NaN #22271.Rationale for this change
DataFusion currently returns
NaNfor negativelninputs. PostgreSQL raises an error for the same case, and issue #22271 tracks aligningln((-1.0)::float8)with that behavior.This keeps the existing
ln(0)behavior unchanged.What changes are included in this PR?
lnfrom the shared unary math macro to a dedicatedLnFuncimplementation.lnreceives a negativeFloat32orFloat64value.scalar.sltto cover positive column inputs plus negative scalar and column error cases.Are these changes tested?
Yes. I ran:
cargo fmt --check -- datafusion/functions/src/math/mod.rs datafusion/functions/src/math/ln.rscargo check -p datafusion-functionscargo test -p datafusion-functions math::ln --libcargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:586cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:593cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:597git diff --checkI also ran
cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar. The changedlnrecords passed, but the full file failed later atscalar.slt:1546+because localaggregate_test_100data was empty in this checkout; those failures were unrelated to this change.Are there any user-facing changes?
Yes.
lnnow errors on negative inputs instead of returningNaN.